Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): disable vertical borders of the update notification #9309

Merged
merged 2 commits into from
Sep 15, 2023
Merged

fix(cli): disable vertical borders of the update notification #9309

merged 2 commits into from
Sep 15, 2023

Conversation

qwerzl
Copy link
Contributor

@qwerzl qwerzl commented Sep 15, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #9239. This is a really small modification. I just added a custom borderStyle to boxenOptions.

Test Plan

I changed notifier in beforeCli in beforeCli.mjs to:

updateNotifier({
    pkg: {
      "docusaurus",
      version: '2.4.0',
    },
    // Check is in background so it's fine to use a small value like 1h
    // Use 0 for debugging
    updateCheckInterval: 0,
  });

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Screenshot ran in WebStorm with zsh:

Related issues/PRs

#9239

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 15, 2023
@netlify
Copy link

netlify bot commented Sep 15, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 20e86ca
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65040c5a5206dd0008980dee
😎 Deploy Preview https://deploy-preview-9309--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

github-actions bot commented Sep 15, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 61 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 84 🟢 98 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 15, 2023
@slorber slorber changed the title fix: disable vertical borders of the update notification fix(cli): disable vertical borders of the update notification Sep 15, 2023
@slorber
Copy link
Collaborator

slorber commented Sep 15, 2023

great idea, didn't know it was possible to remove only a part of the border. Thanks 👍

@slorber slorber merged commit 6e8e276 into facebook:main Sep 15, 2023
31 checks passed
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade notification command does not copy properly due to box borders
3 participants