Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve yarn deps upgrade command #9149

Merged
merged 1 commit into from
Jul 20, 2023
Merged

docs: improve yarn deps upgrade command #9149

merged 1 commit into from
Jul 20, 2023

Conversation

webbertakken
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

#> yarn upgrade
Usage Error: Couldn't find a script named "upgrade".

$ yarn run [--inspect] [--inspect-brk] [-T,--top-level] [-B,--binaries-only] <scriptName> ...

Instead use yarn add to update to the latest version. Also don't add @latest, because that will put the @latest constraint in package.json, which can cause silent major upgrades, as it's a rolling tag.

Test Plan

Test links

It's this page: https://docusaurus.io/docs/installation

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

None

@netlify
Copy link

netlify bot commented Jul 16, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e615347
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/64b413d3d47ae400081cc37d
😎 Deploy Preview https://deploy-preview-9149--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 68 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 69 🟢 100 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jul 20, 2023
@slorber slorber changed the title fix(docs): improve yarn command docs: improve yarn deps upgrade command Jul 20, 2023
@slorber
Copy link
Collaborator

slorber commented Jul 20, 2023

Thanks 👍

As far as I understand it only affects newer Yarn versions where the command is now yarn up. Replacing by add looks like a nice alternative (and it works fine on Yarn v1 too, just tested it)

@slorber slorber merged commit 43d070e into facebook:main Jul 20, 2023
10 checks passed
@webbertakken webbertakken deleted the patch-1 branch July 20, 2023 10:27
slorber pushed a commit to VinceCYLiao/docusaurus that referenced this pull request Aug 3, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants