Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update broken links theme configuration page #8976

Merged
merged 2 commits into from
May 15, 2023

Conversation

rbarbazz
Copy link
Contributor

@rbarbazz rbarbazz commented May 14, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Updated broken links on this page.

Same question as in this other PR I just made, do we want to use links to the current master branch instead of permalinks?

Test Plan

N/A

Test links

Old link: https://docusaurus.io/docs/api/themes/configuration#theme
Deploy preview: https://deploy-preview-8976--docusaurus-2.netlify.app/docs/api/themes/configuration/#theme

Related issues/PRs

Related PR: #8975
Closes: #8968

@netlify
Copy link

netlify bot commented May 14, 2023

[V2]

Name Link
🔨 Latest commit 048dda9
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/646224bcc0b1ec000840ba6b
😎 Deploy Preview https://deploy-preview-8976--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

website/docs/api/themes/theme-configuration.mdx Outdated Show resolved Hide resolved
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 15, 2023
@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 77 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 81 🟢 100 🟢 92 🟢 100 🟠 89 Report

@slorber slorber merged commit 509189e into facebook:main May 15, 2023
@rbarbazz rbarbazz deleted the patch-3 branch May 15, 2023 15:13
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
3 participants