Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention blog truncating marker edge case #8953

Merged
merged 1 commit into from
May 3, 2023

Conversation

allyw2002
Copy link
Contributor

@allyw2002 allyw2002 commented May 1, 2023

This is a documentation change for https://docusaurus.io/docs/blog#blog-list that closes #8653. These changes have been made to all previous versions of the blog page as well :)

(I have read the contributing guidelines but I'm not sure how to mark it off on the checkbox, whoops)

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 1, 2023
@netlify
Copy link

netlify bot commented May 1, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 29ff1c3
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/644f4de604643500082577ad
😎 Deploy Preview https://deploy-preview-8953--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 1, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 78 🟢 100 🟢 92 🟢 100 🟠 89 Report

@slorber
Copy link
Collaborator

slorber commented May 3, 2023

Thanks

To be honest I'm not sure "standalone renderable markdown" will be understood by many users, but maybe it will help some 🤷‍♂️

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 3, 2023
@slorber slorber changed the title Add documentation for truncating docs: mention blog truncating marker edge case May 3, 2023
@slorber slorber merged commit 7e01f36 into facebook:main May 3, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference style links below the truncate marker are not resolved in blog list
3 participants