Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add "permissions.content: write" to GH workflow examples #8877

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

e-minguez
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fixes #8876

Test Plan

None

Test links

N/A

Related issues/PRs

#8876

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 10, 2023
@netlify
Copy link

netlify bot commented Apr 10, 2023

[V2]

Name Link
🔨 Latest commit dbb8282
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6436f271376d6000083b201e
😎 Deploy Preview https://deploy-preview-8877--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 10, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 89 🟢 97 🟢 92 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 92 🟢 100 🟢 90 Report

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I don't think the issue link is necessary (you can either remove it or replace it with something like # Explicitly grant write permission), but otherwise this should be good.

Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Agree that the issue link is not needed

website/docs/deployment.mdx Outdated Show resolved Hide resolved
website/docs/deployment.mdx Outdated Show resolved Hide resolved
@slorber slorber changed the title Added write premissions to GH workflow examples docs: add "permissions.content: write" to GH workflow examples Apr 13, 2023
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 13, 2023
@slorber slorber merged commit 35183d7 into facebook:main Apr 13, 2023
chillinPanda added a commit to chillinPanda/docusaurus that referenced this pull request Oct 6, 2023
…4.3...

this is already documented in the latest version by commit 35183d7

See also facebook#8877

This is also working for v2.4.3 and needed for using GitHub Pages and Actions with the default setting for the action's automatic GITHUB_TOKEN
chillinPanda added a commit to chillinPanda/docusaurus that referenced this pull request Oct 6, 2023
…4.3...

this is already documented in the latest version by commit 35183d7

See also facebook#8877

This is also working for v2.4.3 and needed for using GitHub Pages and Actions with the default setting for the action's automatic GITHUB_TOKEN
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub actions requires more permissions
4 participants