Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document theme-mermaid in API sidebar #8417

Merged
merged 4 commits into from
Dec 7, 2022
Merged

docs: document theme-mermaid in API sidebar #8417

merged 4 commits into from
Dec 7, 2022

Conversation

homotechsual
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Documentation for new theme introduced in 2.2.0.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 7, 2022
@netlify
Copy link

netlify bot commented Dec 7, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit f60ff23
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/639000436fc63f0008dbde33
😎 Deploy Preview https://deploy-preview-8417--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 93 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 78 🟢 100 🟢 100 🟢 100 🟢 90 Report

@homotechsual @Josh-Cena
Update website/docs/api/themes/theme-mermaid.md
8564659 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@homotechsual
Copy link
Contributor Author

I agree about the additional hint/wording not sure quite how to word it.

@homotechsual @Josh-Cena
Update website/docs/api/themes/theme-mermaid.md
f60ff23 
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@Josh-Cena Josh-Cena changed the title docs(content-docs): document theme-mermaid in the api/themes section. docs: document theme-mermaid in API sidebar Dec 7, 2022
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 7, 2022
Josh-Cena
Josh-Cena approved these changes Dec 7, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Josh-Cena Josh-Cena merged commit b7cbc96 into facebook:main Dec 7, 2022
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@homotechsual @Josh-Cena @facebook-github-bot