Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add i18n guide doc should link to i18n core config doc #8392

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

mcallisto
Copy link
Contributor

@mcallisto mcallisto commented Nov 29, 2022

Added direct link to the relevant section of docusaurus.config.js

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

Added direct link to the relevant section of `docusaurus.config.js`
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 29, 2022
@netlify
Copy link

netlify bot commented Nov 29, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit da88c69
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6385fdbdb0c9f70008d028b7
😎 Deploy Preview https://deploy-preview-8392--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 74 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber changed the title Update i18n-introduction.md docs: add i18n guide doc should link to i18n core config doc Nov 30, 2022
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 30, 2022
@slorber
Copy link
Collaborator

slorber commented Nov 30, 2022

Thanks 👍

@slorber slorber merged commit 97ca090 into facebook:main Nov 30, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants