Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update examples after release of Docusaurus v2.1.0 #8041

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 2, 2022

Motivation

Update examples after release of Docusaurus v2.1.0 #8040

@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Sep 2, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 2, 2022
@netlify
Copy link

netlify bot commented Sep 2, 2022

[V2]

Name Link
🔨 Latest commit c7dd5fe
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6311e26ad7c2ca00080dfbc9
😎 Deploy Preview https://deploy-preview-8041--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 66 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 72 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber
Copy link
Collaborator Author

slorber commented Sep 2, 2022

@Josh-Cena FYI the generate example script seems to behave differently now.

Not sure why but it doesn't generate yarn.lock files anymore but generate a package-lock.json file for me locally 🤷‍♂️ (despite using yarn create in the script 😅 )

In practice, it doesn't seem like a big deal, and it was probably not goodto bias toward Yarn in the first place 🤷‍♂️

Sandboxes seem to work fine without the lockfile so I'll merge as is for now

@slorber slorber merged commit 54986a3 into main Sep 2, 2022
@slorber slorber deleted the slorber/2.1.0-examples branch September 2, 2022 11:05
@Josh-Cena
Copy link
Collaborator

Interesting. I'll take a look. I never understood what's going on with the generate examples script—it's doing so many things in one...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants