test: improve e2e verdaccio configuration #7967
Conversation
``` lerna notice total files: 64 775 lerna notice 776 lerna ERR! E503 one of the uplinks is down, refuse to publish 777 error Command failed with exit code 1. 778 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. 779 Error: Process completed with exit code 1. ```
to be removed
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Josh-Cena
added
the
pr: maintenance
|
Great, thank you so much 🙏 |
| # this package is hosted outside the monorepo | ||
| # https://github.com/slorber/react-loadable | ||
| # thus requires to be fetched from npmjs | ||
| '@docusaurus/react-loadable': |
There was a problem hiding this comment.
Is there a way to dynamically figure out which packages are in the local monorepo? In the future we may have more scoped (forked) packages not in the main repo.
There was a problem hiding this comment.
Well, since is committed in the repo is less flexible, but I could try adding the proxy, so any package that match with the namespace is lookup outside so the block above is not need it, it has disadvantages like for every package published will check on npmjs (here is when external network might break your build again).
'@docusaurus/*':
access: $all
publish: $all
proxy: npmjs
Let me know what do you prefer and I can update the config.
Anyhow, I'm working in a different ways, like https://github.com/verdaccio/verdaccio/blob/master/packages/verdaccio/test/unit/proxy-multilpe-registry.spec.ts#L20 programatically generate the yaml files or stuff like that for the next major (still WIP).
There was a problem hiding this comment.
Ah, good to know. For now, I think this hardcoded list is fine—we just anticipate another 2~3 forked dependencies + a few to be moved under this scope (ref #6246)
|
Thanks @juanpicado :) looks great 👍 |
Pre-flight checklist
Motivation
I've notice master fails with
E503 one of the uplinks is down, refuse to publish, this happens because on publish first check on internet if the version of this package exist, for E2E this should not be required. I'm trying to improve the master branch builds.By adding a new block for
@docusaurus/*avoid check any uplink and also the propertyallow_offlineavoid any check with internet on publish (this is handy if the connection is dropped so avoid network issues)The CI build: https://github.com/facebook/docusaurus/runs/7881520546?check_suite_focus=true
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs