-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(content-docs): add tags route as a subroute of version route #6823
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6823--docusaurus-2.netlify.app/ |
Size Change: -238 B (0%) Total Size: 797 kB
ℹ️ View Unchanged
|
I just realized this would create duplicate layouts. With all the |
IMHO we probably need another "layer" We probably don't want to have tags reusing the existing DocPage component. At the same time we want tags to benefit from the version metadata being set in context, and we generally want to keep a shared layout at the very top (ie no unmount/remount on navigation from doc to tag + ability to optimize further later). A good solution now would be to create an extra component like The main problem is Maybe the page class should rather be set on body directly with |
Superseded by #7966 👍 |
Motivation
Complete a TODO. This should prevent the entire page from rerendering?
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
The test snapshots are updated