Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle templates without main package field #8734

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

mrmckeb
Copy link
Contributor

@mrmckeb mrmckeb commented Mar 27, 2020

Some users have hit an issue when creating templates and omitting the main field. As main is not required in package.json, we've simplified the implementation to remove this requirement.

Solution provided by @ianschmitz. Resolves #8560.

@mrmckeb mrmckeb force-pushed the feature/fix-template-resolution branch from 73e581d to 1987721 Compare March 27, 2020 09:32
@ianschmitz ianschmitz added this to the 3.4.2 milestone Mar 27, 2020
@ianschmitz ianschmitz merged commit e0b179c into master Apr 4, 2020
@ianschmitz ianschmitz deleted the feature/fix-template-resolution branch April 4, 2020 23:36
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
@ianschmitz ianschmitz modified the milestones: 3.5, 4.0 May 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants