Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract some utilities into a separate package #723

Merged
merged 3 commits into from
Sep 23, 2016
Merged

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Sep 23, 2016

This makes projects cleaner after ejecting!

@gaearon gaearon added this to the 0.5.0 milestone Sep 23, 2016
@ghost ghost added the CLA Signed label Sep 23, 2016
@fson
Copy link
Contributor

fson commented Sep 23, 2016

Need to add utils to files in packages/react-scripts/package.json

Copy link
Contributor

@fson fson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!
screen shot 2016-09-23 at 20 57 59

@fson
Copy link
Contributor

fson commented Sep 23, 2016

Ok, eject in the e2e test still tries to install our packages from npm.

var prompt = require('react-dev-utils/prompt');
prompt(
'Are you sure you want to eat all the candy?',
false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always put a comment for boolean variables with what they mean, otherwise it's pretty confusing :)

/* isYesDefault*/ false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better:

prompt('Are you sure you want to eat all the candy?', { default: false });

@gaearon gaearon merged commit e5bf5af into master Sep 23, 2016
@gaearon gaearon deleted the react-dev-utils branch September 23, 2016 19:53
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Extract some utilities into a separate package

* Add utils dir to `files` in package.json

* Do not create an empty `utils` dir on eject
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants