Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about unsupported Node.js versions #575

Merged
merged 3 commits into from
Sep 6, 2016
Merged

Conversation

fson
Copy link
Contributor

@fson fson commented Sep 4, 2016

Add the engines field to package.json so users of old Node.js versions
will at least get a warning when trying to install create-react-app:

npm WARN engine react-scripts@0.4.1: wanted: {"node":">=4"} (current: {"node":"2.5.0","npm":"2.13.2"})

Fixes the issue raised in #570.

Add the `engines` field to package.json so users of old Node.js versions
will at least get a warning when trying to install create-react-app or
react-scripts, e.g.:

  npm WARN engine create-react-app@0.3.0: wanted: {"node":">=6"} (current: {"node":"4.2.3","npm":"2.14.7"})
@ghost ghost added the CLA Signed label Sep 4, 2016
@vjeux vjeux merged commit d3530f4 into facebook:master Sep 6, 2016
@fson fson deleted the engines branch September 6, 2016 16:21
stayradiated pushed a commit to stayradiated/create-react-app that referenced this pull request Sep 7, 2016
* Warn about unsupported Node.js versions

Add the `engines` field to package.json so users of old Node.js versions
will at least get a warning when trying to install create-react-app or
react-scripts, e.g.:

  npm WARN engine create-react-app@0.3.0: wanted: {"node":">=6"} (current: {"node":"4.2.3","npm":"2.14.7"})

* Remove duplicated field and extra whitespace

* Change the engine version back to 4
@fson fson added this to the 0.4.2 milestone Sep 10, 2016
@gaearon gaearon mentioned this pull request Sep 18, 2016
feiqitian pushed a commit to feiqitian/create-react-app that referenced this pull request Oct 25, 2016
* Warn about unsupported Node.js versions

Add the `engines` field to package.json so users of old Node.js versions
will at least get a warning when trying to install create-react-app or
react-scripts, e.g.:

  npm WARN engine create-react-app@0.3.0: wanted: {"node":">=6"} (current: {"node":"4.2.3","npm":"2.14.7"})

* Remove duplicated field and extra whitespace

* Change the engine version back to 4
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants