Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch Workbox from CDN #5180

Merged
merged 1 commit into from
Sep 30, 2018
Merged

Fetch Workbox from CDN #5180

merged 1 commit into from
Sep 30, 2018

Conversation

Timer
Copy link
Contributor

@Timer Timer commented Sep 30, 2018

Requests are only made to the CDN if the user opts-in to the Service Worker via index.js.
The calls are not present in our default installation.

@Timer Timer added this to the 2.0.0 milestone Sep 30, 2018
gaearon
gaearon approved these changes Sep 30, 2018
View reviewed changes
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. You confirmed this doesn't produce the "workbox" folder after build by default?

@Timer
Copy link
Contributor Author

Timer commented Sep 30, 2018

Yep!

image

@gaearon
Copy link
Contributor

gaearon commented Sep 30, 2018

Sweet

@Timer
Copy link
Contributor Author

Timer commented Sep 30, 2018

Also tested the service worker still worked, register, offline, and unregistering. Seems to all check out.

@Timer Timer merged commit 70b3110 into facebook:master Sep 30, 2018
@Timer Timer deleted the workbox-cdn branch September 30, 2018 21:58
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Oct 2, 2018
@Timer
Use Workbox CDN as default (facebook#5180)
b2a312a
@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed tag: internal
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Timer @gaearon @facebook-github-bot