Add note about installing watchman #1933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade webpack * Address more webpack v2 ... * Update html-webpack-plugin * Remove LoaderOptionsPlugin from dev config * ExtractTextPlugin still uses webpack 1 syntax ... and doesn't support complex options (yet) * Grammar nit * Update extract text webpack plugin * - Remove webpack.LoaderOptionsPlugin - Update deps * Lerna hoists packages * Update extract-text-webpack-plugin * Update webpack-dev-server * Remove imports for the tests * stop removing babelrc
* Suggest jest-enzyme for simplifying test matchers * Update README.md * Update README.md
* Add SASS support documentation facebook#1007 * Change SASS section title to more generic label * Fix link in Table of Contents * Chain build-css with watch-css script, fix typos * Update Sass and Less naming style * Fix wording, remove offensive words * Slightly rewite
The `test` command fails with multiple arguments when given a unary operator such as '-e'. Add a function that can test one or more files by looping over all files.
* change npm to yarn command * Keep npm primary option
…-app (facebook#1313) * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app * Add more info
* added how to disable autoprefix feature in doc * Just link to the doc
* Tweak syntax doc * Shorter version
* update CSS preprocessor instructions - Windows shell users should note that running two programs simultaneously is not supported. * fix the order of SASS build step - the suggested build step with integrated CSS preprocessing is wrong. The SASS preprocessor should run first, then the react-scripts build will pick the up-to-date final CSS * Add tweaks from PR discussion
* Revert "Don't run CI on Node 0.10" * Install after checking node version * Don't use travis install
* Use Yarn latest in e2e * Here too * And here plz
* Disable require.ensure * Replace require.ensure with import * Add babel plugin for parsing import() * Get the default * Upgrade babel-eslint to support dynamic import * Fix dep * Update deps
* Bump babel deps * Re-enable transform-react-constant-elements Resolves facebook#553
Update links to jest expect function.
* Switch from Neo to Neutrino * Edited format to be consistent
* Fixes a silent crash when ejecting * Delete unnecessary files * Remove references to eslintrc in Webpack config * Fix lint * Correct ESLint CLI options
* Makes end-to-end testing crash on unhandled rejections * Comment fix
* Allow creation of apps in empty mercurial repos * Adding .hgignore to list of validFiles for isSafeToCreateProjectIn check * Adding .hgcheck to list of validFiles for isSafeToCreateProjectIn check
…flict (facebook#1869) * Removed blockquote from code section * Fix the fix
commander to figure it out on its own
* Adding shrink-to-fit=no for proper responsive handling on Safari 9+
Previous changes caused `detect-port` to pick random port on app startup. Update fixes this regression, `detect-port` pick next available port instead.
* Fix importing npm linked libraries * Update webpack.config.dev.js * Update webpack.config.prod.js
* Added test to check for accidental dependencies * Refactored test into a function * Removed non capturing group from grep * Update e2e-installs.sh
* Fix AppVeyor CI (facebook#1876) * Run AppVeyor on Visual Studio 2017
* Upgrade webpack & related deps * Disable module transform (requires webpack 2+)
|
Does this issue still exist? I believe it's an underlying problem with Jest that needs to be fixed. We should probably link and add a disclaimer (e.g. "Until this issue is resolved."). |
|
There have been a lot of discussions in this repo: #871, #991, #1474 But none on them have mentioned, that Jest already merged a PR with the fix: jestjs/jest#2957 Well, at least this PR will now contain this information. |
|
This is probably worth adding to the 0.9.x branch, as it should be fixed with 0.10 and upgrade to Jest 19. |
|
Oh, I have changed the target from master to 0.9.x and something strange had happened. I will send another PR instead of this one later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every new contributor may encounter with the issue: #871
Some additional info in Contributing guide would be useful