Update now instructions to support html5 history #1805
Conversation
Passing the `--single` flag ensure html5 history api support.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions. |
| @@ -1520,7 +1520,7 @@ When you build the project, Create React App will place the `public` folder cont | |||
| 3. Add this line to `scripts` in `package.json`: | |||
|
|
|||
| ``` | |||
| "now-start": "serve build/", | |||
| "now-start": "serve --single build/", | |||
There was a problem hiding this comment.
Let's use serve -s build for consistency with what we now suggest in CLI?
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Do we need that trailing slash? |
|
Seems like this is obsolete with #2372. |
|
I'll close this since it was replaced with #2372; thank you for your contribution @jaredpalmer! |
Passing the
--singleflag to ensure HTML5 history api support (for things like react router).