Remove cached lockfile #11706
Merged
Remove cached lockfile #11706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To go along with facebook#11474, we no longer need the cached lockfile after unpinning all the dependencies. This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.
lukekarrys
force-pushed
the
lk/rm-cached-lockfile
branch
from
ca80708
to
4f3093b
Compare
|
Thanks! |
This was referenced Apr 12, 2022
This was referenced Jul 25, 2022
This was referenced Aug 26, 2022
This was referenced Nov 29, 2022
abhiisheek
pushed a commit
to abhiisheek/create-react-app
that referenced
this pull request
May 24, 2023
This was referenced May 24, 2024
This was referenced May 29, 2024
This was referenced Jun 3, 2024
This was referenced Jun 8, 2024
This was referenced Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go along with #11474, we no longer need the cached lockfile after unpinning all the dependencies.
This PR removes all references to it in the creation of new projects and the tests. It also refactors the integration test to assert that all files exist and no extra ones are being written.