Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on readme #10556

Closed
wants to merge 1 commit into from
Closed

Fix typo on readme #10556

wants to merge 1 commit into from

Conversation

mrnossiom
Copy link

The npm install command is corrupted.

There is a & but it should be a @.

Thanks
MrNossiom

@mrnossiom
Fix typo on readme
9fa85c2 
The npm install command is corrupted.
@mrmckeb mrmckeb added this to the 4.0.3 milestone Feb 15, 2021
mrnossiom
mrnossiom commented Feb 16, 2021
View reviewed changes
Copy link
Author

@mrnossiom mrnossiom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are breaking... We should pass to React v18. 😄

@tobiasbueschel
Copy link
Contributor

tobiasbueschel commented Feb 17, 2021 •
edited
Loading

Hey @mrmckeb is there a chance to merge this soon as it's one of many duplicate PRs that we've already received for this issue:

Hope you are all staying safe & healthy! Cheers

@iansu iansu modified the milestones: 4.0.3, 4.0.4 Feb 22, 2021
@tobiasbueschel
Copy link
Contributor

Adding one more duplicate PR to this list: #10671 🤓

@tobiasbueschel tobiasbueschel mentioned this pull request Mar 14, 2021
Closed
@mrnossiom
Copy link
Author

Maybe we could close some duplicate issues...

@lasseborly lasseborly mentioned this pull request Apr 30, 2021
Closed
@iansu
Copy link
Contributor

iansu commented May 12, 2021

Duplicate of #10317

@iansu iansu marked this as a duplicate of #10317 May 12, 2021
@iansu iansu closed this May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misino misino misino approved these changes

@mrmckeb mrmckeb mrmckeb approved these changes

@tobiasbueschel tobiasbueschel tobiasbueschel approved these changes

@suyundukov suyundukov suyundukov approved these changes

@ianschmitz ianschmitz Awaiting requested review from ianschmitz

@iansu iansu Awaiting requested review from iansu

@petetnt petetnt Awaiting requested review from petetnt

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mrnossiom @tobiasbueschel @iansu @misino @mrmckeb @suyundukov @facebook-github-bot