Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(create-react-app): add integration tests #10381

Merged
merged 5 commits into from
May 12, 2021
Merged

test(create-react-app): add integration tests #10381

merged 5 commits into from
May 12, 2021

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Jan 14, 2021 •
edited
Loading

  • Added integration tests for create-react-app.
  • Added a new GitHub Actions job for integration tests with a build matrix to execute tests on multiple platforms.

@jamesgeorge007 jamesgeorge007 force-pushed the integration-tests branch 3 times, most recently from fa1c0d3 to 2d5d64e Compare January 15, 2021 03:18
mrmckeb
mrmckeb reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@mrmckeb mrmckeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start for new integration tests, thanks @jamesgeorge007.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@jamesgeorge007 jamesgeorge007 changed the title chore: add integration tests test(create-react-app): add integration tests Apr 20, 2021
@mrmckeb
Copy link
Contributor

mrmckeb commented Apr 22, 2021

Just waiting for some thoughts from @ianschmitz and/or @iansu here :)

@iansu iansu mentioned this pull request Apr 28, 2021
Closed
21 tasks
iansu
iansu suggested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@iansu iansu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one small change and we can merge.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@jamesgeorge007 jamesgeorge007 requested a review from iansu May 12, 2021 16:50
@iansu iansu merged commit 7bdeced into facebook:master May 12, 2021
@iansu
Copy link
Contributor

iansu commented May 12, 2021

Thanks!

@jamesgeorge007 jamesgeorge007 deleted the integration-tests branch May 12, 2021 18:15
andriijas pushed a commit that referenced this pull request May 28, 2021
@raix @ianschmitz
@jasonwilliams @Spacerat @shamprasadrh @jamesgeorge007
[WP5] Webpack5 update (#10961)
aaddb29 
* Revert "Revert "Update postcss packages" (#10216)"

This reverts commit 3968923.

* Revert "Update postcss packages" (#10216)

This reverts commit 580ed5d.

* Update postcss and loader

* Update fork-ts-checker-webpack-plugin@5.2.1

References:
* [hook rename](TypeStrong/fork-ts-checker-webpack-plugin#490)
* [include/exclude](TypeStrong/fork-ts-checker-webpack-plugin#450) and [issue options](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin#issues-options)
* [release notes 5.0.0](https://github.com/TypeStrong/fork-ts-checker-webpack-plugin/releases/tag/v5.0.0)

* Update fork-ts-checker-webpack-plugin 6.0.5

* Add css-minimizer-webpack-plugin@1.1.5 remove

Add css-minimizer-webpack-plugin@1.1.5
Remove optimize-css-assets-webpack-plugin and postcss-safe-parser

References:
* https://webpack.js.org/plugins/css-minimizer-webpack-plugin/

* Add support for Webpack 5 message objects

* Update WebpackManifestPlugin to v3.0.0

* Support both "SingleEntryPlugin" and "EntryPlugin"

* Support Webpack 5 IgnorePlugin signature

Reference:
* https://webpack.js.org/plugins/ignore-plugin/#example-of-ignoring-moment-locales
* #10006

* Update webpack and dev server

* Enable persistent cache

* Fix react-error-overlay webpack

* Fix dev server config

* Remove support for SingleEntryPlugin

* update workbox-webpack-plugin

* Fix post css config

* Comment out WebpackManifestPlugin for now having issues with undefined path

* Add fast refresh entries to ModuleScopePlugin

* Format files

* Remove unused variables in start command

* git ignore tsconfig.tsbuildinfo
supporting incremental typescript builds

* simplify output path

review feedback from @kumarlachhani

* Use asset modules in react-scripts

* Use asset modules in react-error-overlay

* eslint-config-react-app typo fix (#10317)

This just fixes a shell snippet in the readme file for this plugin

* Fix link address (#10907)

Replace the Github home link with a link to the repo's main page or a link to the source (https://github.com/CodeByZach/pace/blob/master/pace.js)

* Bump immer version for fixing security issue (#10791)

Bump immer minor version to fix `Prototype Pollution` Security issue.

* test(create-react-app): add integration tests (#10381)

* Revert "Use asset modules in react-error-overlay"

This reverts commit 952f896.

* Disable broken tests for now

* Revert source-map bump in react-error-overlay

* JSON is using default export

* Webpack config: Remove invalid parser configuration

* Fix issue with ModuleScope and babel runtime

* Fix svgr configuration

* Webpack config svg use file-loader instead of url-loader

* Update postcss-normalize

* Fix asset output name

* Update test matrix using node 12+14

postcss normalize only support node >=12

* Fix file output extension

* Align assetModuleFilename

* pipeline update configuration names

* Add back webpack-manifest-plugin

* Fix kitchen sink get actual href value

.href is prefixed with http://localhost etc.

* Update kitchen sink test to webpack 5 asset modules

* Let webpack handle global this

* Fix eject copy config/webpack/persistentCache folder

* Move tsbuildinfo into cache folder

* Update dependencies

* Update webpack-dev-server to beta.3

* Compilation.modules changed to type Set

reference: comment by @slorber #9994 (comment)

* Format JsonInclusion.js using prettier

* Run prettier on webpack dev server config

* Enable e2e behavior tests using node 12+14

* Comment out e2e behavior tests for now

* Add experimental support for module federation

* Fix missing wds socket path update

accordingly to review by @xiaokekeT

* Revert "Add experimental support for module federation"

This reverts commit 8fdc63b.

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: jasonwilliams <jase.williams@gmail.com>
Co-authored-by: Joseph Atkins-Turkish <spacerat3004@gmail.com>
Co-authored-by: e-w-h <46170930+e-w-h@users.noreply.github.com>
Co-authored-by: Shamprasad RH <shamprasad.rh@mail.weir>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
wombleton pushed a commit to AurorNZ/create-react-app that referenced this pull request Jun 1, 2021
@jamesgeorge007 @wombleton
test(create-react-app): add integration tests (facebook#10381)
803cc89
sumanthratna pushed a commit to sumanthratna/create-react-app that referenced this pull request Aug 4, 2021
@jamesgeorge007 @sumanthratna
test(create-react-app): add integration tests (facebook#10381)
4db38c9
@snyk-bot snyk-bot mentioned this pull request Oct 5, 2022
Open
abhiisheek pushed a commit to abhiisheek/create-react-app that referenced this pull request May 24, 2023
@jamesgeorge007 @abhiisheek
test(create-react-app): add integration tests (facebook#10381)
7e865fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmckeb mrmckeb Awaiting requested review from mrmckeb

@iansu iansu Awaiting requested review from iansu

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jamesgeorge007 @mrmckeb @iansu @facebook-github-bot