Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created app has wrong favicon "sizes" value in the manifest file, which results in console error. #3284

Closed
mohsinulhaq opened this issue Oct 15, 2017 · 7 comments

Comments

@mohsinulhaq
Copy link

Is this a bug report?

Yes

Can you also reproduce the problem with npm 4.x?

Did not try. Doesn't seem to be related to that.

Which terms did you search for in User Guide?

I didn't.

Environment

  1. node -v: v8.7.0
  2. npm -v: 5.5.1
  3. yarn --version (if you use Yarn):
  4. npm ls react-scripts (if you haven’t ejected):

Then, specify:

  1. Operating system: macOS 10.13
  2. Browser and version (if relevant): Chrome 61

Steps to Reproduce

  1. Go to the created app's manifest file in public folder.
  2. The icons array has wrongly mentioned the favicon.ico size as 192x192 instead of 16x16 size of the included favicon file.
  3. Run the app. Go to Dev Tools' Application section. Open Manifest.
  4. Click Add to homescreen. This results in console error:
    Error while trying to use the following icon from the Manifest: http://localhost:3000/favicon.ico (Resource size is not correct - typo in the Manifest?) Site cannot be installed: icon downloaded from the manifest was empty or corrupted

Expected Behavior

Should have searched for 144x144 image, where it would fail if we fix the size now.

Actual Behavior

Console error.

Reproducible Demo

screen shot 2017-10-15 at 9 05 51 pm

ryansully added a commit to ryansully/create-react-app that referenced this issue Oct 16, 2017
@ryansully
Copy link
Contributor

The included favicon.ico file I found was 64x64 instead of 16x16, so I used that value in #3287.

@mohsinulhaq
Copy link
Author

@ryansully yes, you are right, it's 64x64. My IDE wrongly showed it to be 16x16. My bad.

@mohsinulhaq
Copy link
Author

@ryansully have you signed the CLA here https://code.facebook.com/cla to get your PR approved?

@ryansully
Copy link
Contributor

That's odd, I've signed it and contributed before, should I sign again?

@ryansully
Copy link
Contributor

Actually, #3287 has the CLA Signed label:
#3287 (comment)

PR should be ready to go.

gaearon pushed a commit that referenced this issue Oct 28, 2017
zmitry pushed a commit to zmitry/create-react-app that referenced this issue Aug 14, 2018
@camux
Copy link

camux commented Nov 8, 2018

I see this warning but icon size is 64x64 how remove this warning?

@abhishekakade
Copy link

I see this warning but icon size is 64x64 how remove this warning?

@camux, in your app, go to public folder, right click on favicon.ico file and select Properties, then Details tab and check Dimensions value. Then open manifest.json file (which is in the same public folder) in a code editor and under "icons", change "sizes" value to whatever dimensions the favicon.ico file had. That should fix the console error.

@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants