Adding a --no-bin-links option

[sofianegargouri]

Hi !

Is there a way to add a NPM-like --no-bin-links option.
It is used by VM users who share folders between a host and a VM.

Example:
Vagrant

[Reanmachine]

@sofianegargouri

As a side note, you're going to have a hellish time running Jest in your setup. The project analysis in jest last time i used it was stat() heavy. One of the areas the shared folder situation fails miserably in solutions like Vagrant (On Virtualbox at least) is IOPS.

It may have changed since my last time using jest but I know it was this slow IOPS problem that drove me to use a native linux machine for development instead of a VM from windows.

[gaearon]

I'm not entirely sure what you're asking. Can you provide a more detailed feature request? What would this flag do, compared to how we're doing things now?

[sofianegargouri]

I guess that actually you are creating some links while running the commands, but it can break when there are shared folders between 2 different systems (as for Vagrant users). To prevent that, NPM added an option to prevent those Symlinks.

As written in their documentation:

The --no-bin-links argument will prevent npm from creating symlinks for any binaries the package might contain.

I don't know if it is understandable, but when I tried to create a project, I had many conflicts with symlinks that prevented me from using your amazing tool.

[gaearon]

Oh, I see. So you'd like create-react-app myapp --no-bin-links to pass that option down to npm install call, is that correct?

[gaearon]

This should be an easy first PR.

[sofianegargouri]

I don't know if it's only needed in npm install as I wasn't able to go further

[gaearon]

If Yarn supports it then in both. Check if Yarn supports it by inspecting its source 😉

[jkomyno]

I actually tried to add "--no-bin-links" to this line, however I ended up with this:

Installing react-scripts...
npm ERR! Linux 3.2.0-23-generic
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "install" "--save-dev" "--save-exact" "--no-bin-links" "react-scripts"
npm ERR! node v6.9.5
npm ERR! npm v3.10.10

npm ERR! Maximum call stack size exceeded

[gaearon]

File a bug with npm?

[Reanmachine]

@gaearon This is a common bug with npm with --no-bin-links, it typically involves dependency cycles see npm#9224.

When you have dependencies that have cycles in the graph the symlinks tend to solve the problem but when you tell npm it can't symlink it blows up recursing forever until the npm call stack is exhausted.

The desire for the --no-bin-links option typically comes with working on windows (where symlinking doesn't exist or requires elevation), or with vagrants vms (shared folders between a linux vm and a windows host) has issues with creating/maintaining symlinks.

My first guess would be that there's a dependency cycle happening somewhere in one of the many dependencies of react-scripts but realistically that could be upstream in anything or local to CRA.

[gaearon]

Thanks for explaining.

[jkomyno]

Here they seem to suggest that it's a problem with npm 3 and/or Node >= 6. At the moment I can't verify it, i'll give it a look tonight

[shubheksha]

I'd like to take this up!

[vinizinmoraes]

There is another option that worked pretty well for me, on Vagrant

config.vm.provider "virtualbox" do |v|
    v.customize ["setextradata", :id, "VBoxInternal2/SharedFoldersEnableSymlinksCreate/v-root", "1"]
end

Execute CMD with admin rights.

[Timer]

I'm going to free this issue back up, @shubheksha let us know if you'd still like to work on it!

[anilreddykatta]

@Timer If you can brief me about what is the final expected result. I can take up this!

[pastinepolenta]

Any news on this ? It is quite crucial to use CRA on Vagrant boxes

[Timer]

Feel free to submit a PR @stilllife00; and sorry about never responding @anilreddykatta!

See expectation here: #1394 (comment)

[tdfranklin]

@Timer @gaearon
I'd like to give this issue a try if still available. This will be my first contribution; I'm trying to get into open source.

[calihack81]

congrats im prou of a fellow franklin

…

On Wed, Feb 14, 2018 at 3:43 PM, Tyler D Franklin ***@***.***> wrote: @Timer <https://github.com/timer> @gaearon <https://github.com/gaearon> I'd like to give this issue a try if still available. This will be my first contribution; I'm trying to get into open source. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1394 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AT6QPqpYwLyouqxBxX8fK-Hkz4pDTHuhks5tU2GcgaJpZM4LkkHA> .

[iansu]

@tdfranklin Go for it!

[tdfranklin]

@iansu
Thank you! I "think" I've resolved the issue, however I wanted to do some testing to make sure everything was getting passed down correctly and running into some trouble I was hoping you could advise on. I apologize in advance if I'm overlooking an obvious answer, but once I've saved the code, how can I install it to test the command line args?

On my other project, I would just run npm install -g from the project directory then go test the commands in another directory, but I get an error with this project because there is no package name in the package.json (I get a similar error trying to run yarn add /path/create-react-app). I'm new to using Yarn, so I might be missing something obvious....

In the contributing.md file, I see you say to run yarn create-react-app my-app to test the end-to-end flow of the CLI, but I get an error with that because I have uncommitted changes. Do I need to actually commit before I'm able to test or is there a better way to test the CLI commands?

[iansu]

That is probably the best way to test your changes. You can commit your changes and then, if you need to make additional changes, create more commits. It's fine to make multiple commits. We squash them all into a single commit when we merge them anyway.

[tdfranklin]

Ok, great, will do! Thank you for the help!

[tdfranklin]

@iansu
Just wanted to let you know that I submitted a PR:
#4036

However, I see that the CI tests failed, but it looked to be some other issue. If there's something else I need to fix or do, please let me know! Thank you.

[stale]

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

[stale]

This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

[petetnt]

Another PR pending for this at #7243