Skip to content

Commit

Permalink
fomrat code
Browse files Browse the repository at this point in the history
  • Loading branch information
tuchk4 committed Mar 15, 2017
1 parent fd86bdd commit dbdbfb1
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 17 deletions.
16 changes: 8 additions & 8 deletions packages/react-scripts/config/loadEnv.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,24 @@ var fs = require('fs');
var paths = require('./paths');

var sequence = {
'development': [
development: [
paths.dotenvDevelopmentLocal,
paths.dotenvDevelopment,
paths.dotenvLocal,
paths.dotenv
paths.dotenv,
],
'test': [
test: [
paths.dotenvTestLocal,
paths.dotenvTest,
paths.dotenvLocal,
paths.dotenv
paths.dotenv,
],
'production': [
production: [
paths.dotenvProductionLocal,
paths.dotenvProduction,
paths.dotenvLocal,
paths.dotenv
]
paths.dotenv,
],
};

var envConfigs = sequence[process.env.NODE_ENV];
Expand All @@ -46,7 +46,7 @@ if (envConfigs) {
if (fs.existsSync(envConfig)) {
require('dotenv').config({
silent: true,
path: envConfig
path: envConfig,
});
}
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,27 @@ describe('Integration', () => {
it('file env variables', async () => {
const doc = await initDOM('file-env-variables');

expect(doc.getElementById('feature-file-env-original-1').textContent).to.equal('from-original-env-1');
expect(doc.getElementById('feature-file-env-original-2').textContent).to.equal('override-from-original-local-env-2');
expect(
doc.getElementById('feature-file-env-original-1').textContent
).to.equal('from-original-env-1');
expect(
doc.getElementById('feature-file-env-original-2').textContent
).to.equal('override-from-original-local-env-2');

if (process.env.NODE_ENV === 'production') {
expect(doc.getElementById('feature-file-env').textContent).to.equal('production')
expect(doc.getElementById('feature-file-env-x').textContent).to.equal('x-from-production-env')
expect(doc.getElementById('feature-file-env').textContent).to.equal(
'production'
);
expect(doc.getElementById('feature-file-env-x').textContent).to.equal(
'x-from-production-env'
);
} else {
expect(doc.getElementById('feature-file-env').textContent).to.equal('development')
expect(doc.getElementById('feature-file-env-x').textContent).to.equal('x-from-development-env')
expect(doc.getElementById('feature-file-env').textContent).to.equal(
'development'
);
expect(doc.getElementById('feature-file-env-x').textContent).to.equal(
'x-from-development-env'
);
}
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@ import React from 'react';

export default () => (
<span>
<span id="feature-file-env-original-1">{process.env.REACT_APP_ORIGINAL_1}</span>
<span id="feature-file-env-original-2">{process.env.REACT_APP_ORIGINAL_2}</span>
<span id="feature-file-env">{process.env.REACT_APP_DEVELOPMENT}{process.env.REACT_APP_PRODUCTION}</span>
<span id="feature-file-env-original-1">
{process.env.REACT_APP_ORIGINAL_1}
</span>
<span id="feature-file-env-original-2">
{process.env.REACT_APP_ORIGINAL_2}
</span>
<span id="feature-file-env">
{process.env.REACT_APP_DEVELOPMENT}{process.env.REACT_APP_PRODUCTION}
</span>
<span id="feature-file-env-x">{process.env.REACT_APP_X}</span>
</span>
);

0 comments on commit dbdbfb1

Please sign in to comment.