Skip to content

Commit

Permalink
Feed correct line number to gvim on launch (#5202)
Browse files Browse the repository at this point in the history
Clicking Error overlay should feed the correct line number for gvim.

Added `gvim` in `COMMON_EDITORS_LINUX`, launches new gvim when it is running.

Tested with gvim 8.0.707 on a Debian 4.9.110-3+deb9u4 (2018-08-21) x86_64 GNU/Linux VM

Relates to #2636.
  • Loading branch information
identor authored and gaearon committed Oct 1, 2018
1 parent b103376 commit bf5a4bf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/react-dev-utils/launchEditor.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ const COMMON_EDITORS_LINUX = {
code: 'code',
'code-insiders': 'code-insiders',
emacs: 'emacs',
gvim: 'gvim',
'idea.sh': 'idea',
'phpstorm.sh': 'phpstorm',
'pycharm.sh': 'pycharm',
Expand Down Expand Up @@ -136,6 +137,7 @@ function getArgumentsForLineNumber(
case 'vim':
case 'mvim':
case 'joe':
case 'gvim':
return ['+' + lineNumber, fileName];
case 'emacs':
case 'emacsclient':
Expand Down

0 comments on commit bf5a4bf

Please sign in to comment.