Skip to content

Commit

Permalink
Remove 'guard-for-in' lint rule (#1773)
Browse files Browse the repository at this point in the history
Iterating over an object's keys using `for/in` is idiomatic and it's safe (in all modern browsers) to not check hasOwnProperty as long as the object is a plain object. Can we remove this lint rule?
  • Loading branch information
sophiebits authored and gaearon committed Mar 9, 2017
1 parent f4a4e8f commit 6ca7a7b
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion packages/eslint-config-react-app/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ module.exports = {
'default-case': ['warn', { commentPattern: '^no default$' }],
'dot-location': ['warn', 'property'],
eqeqeq: ['warn', 'allow-null'],
'guard-for-in': 'warn',
'new-parens': 'warn',
'no-array-constructor': 'warn',
'no-caller': 'warn',
Expand Down

0 comments on commit 6ca7a7b

Please sign in to comment.