Ensure proxy url starts with http:// or https:// (#1890)

facebook · Apr 15, 2017 · 10dfd89 · 10dfd89
1 parent 3d8c820
commit 10dfd89
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/packages/react-scripts/scripts/start.js b/packages/react-scripts/scripts/start.js
@@ -188,6 +188,14 @@ function addMiddleware(devServer) {
       console.log(chalk.red('Instead, the type of "proxy" was "' + typeof proxy + '".'));
       console.log(chalk.red('Either remove "proxy" from package.json, or make it a string.'));
       process.exit(1);
+      // Test that proxy url specified starts with http:// or https://
+    } else if (!/^http(s)?:\/\//.test(proxy)) {
+      console.log(
+        chalk.red(
+          'When "proxy" is specified in package.json it must start with either http:// or https://'
+        )
+      );
+      process.exit(1);
     }
 
     // Otherwise, if proxy is specified, we will let it handle any request.