Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Ant build completes under 9.0.1 #1672

Closed
wants to merge 3 commits into from
Closed

Conversation

epkugelmass
Copy link
Contributor

@epkugelmass epkugelmass commented Dec 11, 2017

This is a demonstration patch and is not meant to be merged.

Ant build completes under jdk 9.0.1
but with AutoValue annotation processor failures
the resulting buck binaries are unable to build buck

for autovalue annotation processor failures -- see google/auto#560 and related tickets

Question for the buck maintainers -- clearly this patch is not backward compatible with java 8. what's the policy for this project?

referencing issue #1548

but with AutoValue annotation processor failures
the resulting buck binaries are unable to build buck
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

@epkugelmass has updated the pull request. View: changes

@facebook-github-bot
Copy link
Contributor

@epkugelmass has updated the pull request. View: changes

@styurin styurin requested a review from jkeljo December 12, 2017 08:01
@styurin
Copy link

styurin commented Feb 21, 2018

@epkugelmass have you tried to build Java 9 code with buck using out of the process compilation?

@bobyangyf
Copy link
Contributor

Unfortunately buck doesn't work with Java 9.
There's a number of issues in terms of compatibility that even if we were to get it to build, buck would not run properly.

It is on the backlog to modernize it newer standards of java.

#1548 tracks this

@bobyangyf bobyangyf closed this Apr 10, 2018
@navkast navkast deleted the elan/jdk9 branch December 17, 2020 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants