Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AuxiliaryExperimentCheck transition criterion #2778

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ItsMrLin
Copy link
Contributor

Summary: add AuxiliaryExperimentCheck transition criterion

Differential Revision: D63035595

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.71%. Comparing base (331da3a) to head (01d49fb).

Files with missing lines Patch % Lines
ax/modelbridge/transition_criterion.py 96.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2778   +/-   ##
=======================================
  Coverage   95.71%   95.71%           
=======================================
  Files         492      492           
  Lines       48583    48631   +48     
=======================================
+ Hits        46499    46546   +47     
- Misses       2084     2085    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Oct 3, 2024
Summary:
Pull Request resolved: facebook#2778

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Oct 3, 2024
Summary:
Pull Request resolved: facebook#2778

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Oct 3, 2024
Summary:
Pull Request resolved: facebook#2778

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@ItsMrLin ItsMrLin force-pushed the export-D63035595 branch 2 times, most recently from 5f69d27 to ed0b5cf Compare October 3, 2024 19:59
ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Oct 3, 2024
Summary:

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

ItsMrLin added a commit to ItsMrLin/Ax that referenced this pull request Oct 4, 2024
Summary:

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

Summary:

add `AuxiliaryExperimentCheck` transition criterion

Differential Revision: D63035595
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63035595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants