Add _maybe_clear_multiplexer method to deal with memory leaks #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60935886 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 493 493
Lines 47612 47615 +3
=======================================
+ Hits 45360 45363 +3
Misses 2252 2252 ☔ View full report in Codecov by Sentry. |
|
This pull request was exported from Phabricator. Differential Revision: D60935886 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 8, 2024
…ok#2642) Summary: Pull Request resolved: facebook#2642 Adds _maybe_clear_multiplexer method, which is a no-op on base TensorboardMetric, to be implemented on its children where more is known about the multiplexer used. Reviewed By: mpolson64 Differential Revision: D60935886
bernardbeckerman
force-pushed
the
export-D60935886
branch
from
a5acd65
to
bbfddfd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60935886 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 8, 2024
…ok#2642) Summary: Pull Request resolved: facebook#2642 Adds _maybe_clear_multiplexer method, which is a no-op on base TensorboardMetric, to be implemented on its children where more is known about the multiplexer used. Reviewed By: mpolson64 Differential Revision: D60935886
bernardbeckerman
force-pushed
the
export-D60935886
branch
from
bbfddfd
to
de4ba16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60935886 |
bernardbeckerman
pushed a commit
to bernardbeckerman/Ax
that referenced
this pull request
Aug 8, 2024
…ok#2642) Summary: Pull Request resolved: facebook#2642 Adds _maybe_clear_multiplexer method, which is a no-op on base TensorboardMetric, to be implemented on its children where more is known about the multiplexer used. Reviewed By: mpolson64 Differential Revision: D60935886
bernardbeckerman
force-pushed
the
export-D60935886
branch
from
de4ba16
to
9ec85c6
Compare
…ok#2642) Summary: Pull Request resolved: facebook#2642 Adds _maybe_clear_multiplexer method, which is a no-op on base TensorboardMetric, to be implemented on its children where more is known about the multiplexer used. Reviewed By: mpolson64 Differential Revision: D60935886
|
This pull request was exported from Phabricator. Differential Revision: D60935886 |
bernardbeckerman
force-pushed
the
export-D60935886
branch
from
9ec85c6
to
18550b1
Compare
|
This pull request has been merged in e07ea3d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds _maybe_clear_multiplexer method, which is a no-op on base TensorboardMetric, to be implemented on its children where more is known about the multiplexer used.
Differential Revision: D60935886