save status quo name and feature when multiple status quo present #2457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D57309789 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2457 +/- ##
=======================================
Coverage 95.31% 95.31%
=======================================
Files 497 497
Lines 48349 48370 +21
=======================================
+ Hits 46083 46104 +21
Misses 2266 2266 ☔ View full report in Codecov by Sentry. |
ItsMrLin
added a commit
to ItsMrLin/Ax
that referenced
this pull request
May 14, 2024
…acebook#2457) Summary: When multiple status_quo is present in the data, we should still be able to save status quo name and features, which should be the same for all these status quos. Differential Revision: D57309789
ItsMrLin
force-pushed
the
export-D57309789
branch
from
81c23cb
to
945f570
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57309789 |
…acebook#2457) Summary: When multiple status_quo is present in the data, we should still be able to save status quo name and features, which should be the same for all these status quos. Reviewed By: esantorella Differential Revision: D57309789
ItsMrLin
force-pushed
the
export-D57309789
branch
from
945f570
to
9a45af5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57309789 |
|
This pull request has been merged in 6092ac3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When multiple status_quo is present in the data, we should still be able to save status quo name and features, which should be the same for all these status quos.
Differential Revision: D57309789