Switch legacy LCE-A to qLogNEI from legacy ei_or_nei
#2352
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D56037477 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2352 +/- ##
==========================================
+ Coverage 94.91% 94.93% +0.02%
==========================================
Files 491 495 +4
Lines 47788 48057 +269
==========================================
+ Hits 45356 45622 +266
- Misses 2432 2435 +3 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Apr 12, 2024
Summary: Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them. Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address. **[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?** Reviewed By: saitcakmak Differential Revision: D56037477
lena-kashtelyan
force-pushed
the
export-D56037477
branch
from
f1387a5
to
d935cad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56037477 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Apr 12, 2024
Summary: Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them. Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address. **[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?** Reviewed By: saitcakmak Differential Revision: D56037477
lena-kashtelyan
force-pushed
the
export-D56037477
branch
from
d935cad
to
4a7d5e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56037477 |
Summary: Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of `GenerationStrategy`, which these classes hack around, so there's substantial maintenance burden to keeping them. Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address. **[RfC] But also this made me wonder: maybe better to replace use of `ei_or_nei` in LCE-A with something newer?** Reviewed By: saitcakmak Differential Revision: D56037477
lena-kashtelyan
force-pushed
the
export-D56037477
branch
from
4a7d5e9
to
ec91fda
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56037477 |
|
This pull request has been merged in 25c4d0d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context for this stack: we've been meaning to deprecate ALEBO and REMBO for a long time. Tests on them break periodically and slow down development of
GenerationStrategy, which these classes hack around, so there's substantial maintenance burden to keeping them.Context for this diff: LCE-A was depending on ALEBO for, it seems, no reason other than convenience of where the acquisition function constructor lived. This diff aims to address.
[RfC] But also this made me wonder: maybe better to replace use of
ei_or_neiin LCE-A with something newer?Reviewed By: saitcakmak
Differential Revision: D56037477