Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve flakey test reliability #2246

Closed
wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Mar 5, 2024

Summary: set seeds to reduce flakiness

Reviewed By: bernardbeckerman

Differential Revision: D54508799

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Mar 5, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54508799

Summary:

set seeds to reduce flakiness

Reviewed By: bernardbeckerman

Differential Revision: D54508799
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54508799

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (d3f464d) to head (893cf90).

❗ Current head 893cf90 differs from pull request most recent head cd0139b. Consider uploading reports for the commit cd0139b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2246   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files         467      467           
  Lines       46442    46447    +5     
=======================================
+ Hits        44055    44060    +5     
  Misses       2387     2387           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 39c6922.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants