Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call "get_improvement_over_baseline" when making scheduler log #2050

Closed
wants to merge 1 commit into from
Closed

Call "get_improvement_over_baseline" when making scheduler log #2050

wants to merge 1 commit into from

Conversation

mgrange1998
Copy link
Contributor

Summary: Integrating SchedulerCompletedRecord.from_scheduler with scheduler.get_improvement_over_baseline

Differential Revision: D51858443

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
1cba6a7 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Differential Revision: D51858443
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
eaf8bf3 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Differential Revision: D51858443
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f76f721) 94.52% compared to head (9f96ae2) 94.52%.

❗ Current head 9f96ae2 differs from pull request most recent head 9fe7226. Consider uploading reports for the commit 9fe7226 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2050   +/-   ##
=======================================
  Coverage   94.52%   94.52%           
=======================================
  Files         460      460           
  Lines       44625    44638   +13     
=======================================
+ Hits        42182    42195   +13     
  Misses       2443     2443

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
90c314f 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Reviewed By: mpolson64

Differential Revision: D51858443
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
2f0761d 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Reviewed By: mpolson64

Differential Revision: D51858443
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
9fe7226 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Reviewed By: mpolson64

Differential Revision: D51858443
mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
@facebook-github-bot
Call "get_improvement_over_baseline" when making scheduler log (faceb…
64ce51a 
…ook#2050)

Summary:

Integrating  SchedulerCompletedRecord.from_scheduler with `scheduler.get_improvement_over_baseline`

Reviewed By: mpolson64

Differential Revision: D51858443
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51858443

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 46e61d1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgrange1998 @facebook-github-bot @codecov-commenter