Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment exp_to_df with a "reason" column #1973

Closed
wants to merge 1 commit into from
Closed

Augment exp_to_df with a "reason" column #1973

wants to merge 1 commit into from

Conversation

eonofrey
Copy link
Contributor

@eonofrey eonofrey commented Nov 9, 2023

Summary: Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Differential Revision: D51140675

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 9, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aada4cf) 94.51% compared to head (50dc520) 94.51%.

❗ Current head 50dc520 differs from pull request most recent head 2a57cad. Consider uploading reports for the commit 2a57cad to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   94.51%   94.51%   -0.01%     
==========================================
  Files         460      460              
  Lines       44258    44268      +10     
==========================================
+ Hits        41832    41841       +9     
- Misses       2426     2427       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eonofrey pushed a commit to eonofrey/Ax that referenced this pull request Nov 9, 2023
@facebook-github-bot
Augment exp_to_df with a "reason" column (facebook#1973)
e4003ed 
Summary:

Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Differential Revision: D51140675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

eonofrey pushed a commit to eonofrey/Ax that referenced this pull request Nov 9, 2023
@facebook-github-bot
Augment exp_to_df with a "reason" column (facebook#1973)
a191388 
Summary:

Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Differential Revision: D51140675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

eonofrey pushed a commit to eonofrey/Ax that referenced this pull request Nov 9, 2023
@facebook-github-bot
Augment exp_to_df with a "reason" column (facebook#1973)
9f0ee9e 
Summary:

Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Differential Revision: D51140675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

eonofrey pushed a commit to eonofrey/Ax that referenced this pull request Nov 9, 2023
@facebook-github-bot
Augment exp_to_df with a "reason" column (facebook#1973)
d4b8302 
Summary:

Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Differential Revision: D51140675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

@eonofrey @facebook-github-bot
Augment exp_to_df with a "reason" column (facebook#1973)
2a57cad 
Summary:

Augment exp_to_df with a "reason" column, which will surface the failure or abandonment reason string

Reviewed By: mpolson64

Differential Revision: D51140675
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51140675

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3779284.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eonofrey @facebook-github-bot @codecov-commenter