address lint+pyre failures (#2244)

Summary:
Pull Request resolved: #2244

OSS linter seems to be failing (https://github.com/facebook/Ax/actions/runs/8142510522/job/22252224158). This addresses the observed failures.

May be related to https://fb.workplace.com/groups/aeeng/permalink/1603431750415515/

Also moves some pyre-ignores that were out of place, per failing pyre command.

Reviewed By: mpolson64

Differential Revision: D54492153

fbshipit-source-id: 3b553f435fb60da6190cfd15ae29e82a336f4aaa

ax/runners/tests/test_single_running_trial_mixin.py

@@ -14,9 +14,8 @@
 from ax.utils.testing.core_stubs import get_branin_experiment
 
 
-class SyntheticRunnerWithSingleRunningTrial(
-    SingleRunningTrialMixin, SyntheticRunner
-): ...
+class SyntheticRunnerWithSingleRunningTrial(SingleRunningTrialMixin, SyntheticRunner):
+    pass
 
 
 class SingleRunningTrialMixinTest(TestCase):

ax/service/tests/scheduler_test_utils.py

@@ -96,9 +96,8 @@ def poll_trial_status(
         return {}
 
 
-class SyntheticRunnerWithSingleRunningTrial(
-    SingleRunningTrialMixin, SyntheticRunner
-): ...
+class SyntheticRunnerWithSingleRunningTrial(SingleRunningTrialMixin, SyntheticRunner):
+    pass
 
 
 class SyntheticRunnerWithPredictableStatusPolling(SyntheticRunner):

ax/service/tests/test_scheduler.py

@@ -8,4 +8,5 @@
 from ax.service.tests.scheduler_test_utils import AxSchedulerTestCase
 
 
-class TestAxScheduler(AxSchedulerTestCase): ...
+class TestAxScheduler(AxSchedulerTestCase):
+    pass

ax/service/utils/instantiation.py

@@ -271,8 +271,9 @@ def _make_fixed_param(
             parameter_type=(
                 cls._get_parameter_type(type(value))  # pyre-ignore[6]
                 if parameter_type is None
+                # pyre-ignore[6]
                 else cls._get_parameter_type(PARAM_TYPES[parameter_type])
-            ),  # pyre-ignore[6]
+            ),
             value=value,  # pyre-ignore[6]
             is_fidelity=checked_cast(bool, representation.get("is_fidelity", False)),
             target_value=representation.get("target_value", None),  # pyre-ignore[6]

ax/utils/testing/core_stubs.py

@@ -1990,7 +1990,9 @@ def get_percentile_early_stopping_strategy() -> PercentileEarlyStoppingStrategy:
     )
 
 
-def get_percentile_early_stopping_strategy_with_non_objective_metric_name() -> PercentileEarlyStoppingStrategy:  # noqa
+def get_percentile_early_stopping_strategy_with_non_objective_metric_name() -> (
+    PercentileEarlyStoppingStrategy
+):
     return PercentileEarlyStoppingStrategy(
         metric_names=["foo"],
         percentile_threshold=0.25,