Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quotation from git commitUrl #89

Merged
merged 1 commit into from
Sep 9, 2019
Merged

Remove quotation from git commitUrl #89

merged 1 commit into from
Sep 9, 2019

Conversation

felipepodesta
Copy link
Contributor

Remove quotation from git commitUrl on Git Context Tab.

@felipepodesta
Remove quotation from git commitUrl
c297843 
Remove quotation from git commitUrl on Git Context Tab.
@mpociot
Copy link
Contributor

mpociot commented Sep 4, 2019

Thank you for the PR. Can you show me an example of where this was wrong?

@felipepodesta
Copy link
Contributor Author

Thank you for the PR. Can you show me an example of where this was wrong?

Yes, the url is coming with single quotes.

image

freekmurze
freekmurze approved these changes Sep 9, 2019
View reviewed changes
Copy link
Collaborator

@freekmurze freekmurze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've never seen quotes in hashes before, but I guess this PR can't hurt.

@mpociot mpociot merged commit dbe368d into facade:master Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freekmurze freekmurze freekmurze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felipepodesta @mpociot @freekmurze