feat(fabric.controlsUtils) Move drag to actions to control handlers #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asturur
commented
Sep 26, 2020
src/controls.actions.js
Outdated
| @@ -31,7 +31,8 @@ | |||
| function fireEvent(eventName, options) { | |||
| var target = options.transform.target, | |||
| canvas = target.canvas, | |||
| canvasOptions = Object.assign({}, options, { target: target }); | |||
| canvasOptions = fabric.util.clone(options); | |||
Merged
Merged
shanicerae
pushed a commit
to shanicerae/fabric.js
that referenced
this pull request
Jan 16, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No practical changes.
Move the ability to move an object outside the Canvas class, into controls utils.
Also fix a ie11 bug
close #6565
close #6607