Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(canvas): respect imageSmoothingEnabled for canvas export #6280

Merged
merged 10 commits into from
Apr 20, 2020
Merged

fix(canvas): respect imageSmoothingEnabled for canvas export #6280

merged 10 commits into from
Apr 20, 2020

Conversation

asturur
Copy link
Member

@asturur asturur commented Apr 19, 2020 •
edited
Loading

close #6194
close #6276

  • set imageSmoothingEnabled before every render
  • added Image.imageSmoothing for fabric image objects
  • added fabric.util.setImageSmoothing(ctx, value)
  • added svg import/export for image image-rendering attribute

BREAKING:

  • removed 1 utils member that were not used anywhere: fabric.util.getScript
  • remove the export fabric.util.getElementStyle
  • remove private member _setImageSmoothing in the canvas

@asturur asturur changed the title fix(canvas): respect imageSmoothingEnabled for canvas fix(canvas): respect imageSmoothingEnabled for canvas export Apr 19, 2020
@asturur asturur merged commit c7b40a5 into master Apr 20, 2020
@asturur asturur deleted the fix-image-smoothing-toDataUrl branch August 9, 2020 04:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toSVG() breaks if image.src is empty canvas.imageSmoothingEnabled is not used on canvas.toDataURL()
1 participant
@asturur