reHSLa and reRGBa ignore case #5017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignore case for rgba
fabric.Color.reRGBa regex ignore case
ignore case for hsla
fabric.Color.reRGBa regex ignore case
|
I think this is OK. |
|
Do you mind adding a small test to the suite to test it? like at file test/unit/color.js |
added test case for RGB/RGBA and HSL/HSLA (uppercase)
test case RGBA / HSLA
|
I added. |
asturur
reviewed
Jun 2, 2018
test/unit/color.js
Outdated
| oColor.setSource([255,255,255,0.8]); | ||
| assert.equal(oColor.toHexa(), 'FFFFFFCC'); | ||
| oColor.setSource([255,255,255,0.1]); | ||
| assert.equal(oColor.toHexa(), 'FFFFFF1A'); |
There was a problem hiding this comment.
can i ask you the reason of this change here? i remember this one was here because of weird decimals.
There was a problem hiding this comment.
changed that to original
Merged
thiagocunha
pushed a commit
to thiagocunha/fabric.js
that referenced
this pull request
Nov 18, 2019
* fabric.Color.reRGBa regex ignore case ignore case for rgba * fabric.Color.reHSLa ignore case ignore case for hsla * test case RGBA / HSLA added test case for RGB/RGBA and HSL/HSLA (uppercase) * Update color.js
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore case for rgba and hsla, as if pass in uppercase it was returning default color