Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rect element doesn't seem to be parsed correctly #25

Closed
fudini opened this issue Apr 17, 2011 · 6 comments
Closed

rect element doesn't seem to be parsed correctly #25

fudini opened this issue Apr 17, 2011 · 6 comments

Comments

@fudini
Copy link

fudini commented Apr 17, 2011

Adding a rect element to any of test files breaks it when using parseSVGDocument method.

@kangax
Copy link
Member

kangax commented Apr 28, 2011

I can't reproduce this. Just added a test and it works. 7a28d27

Do you have a failing example?

@kangax kangax closed this as completed Apr 28, 2011
@fudini
Copy link
Author

fudini commented Apr 29, 2011

Here is the link to my page with the problem (requires inline svg support):
http://blog.fudini.net/pages/test/fabric

I also noticed that 2 of the fabric.Rect unit tests are failing.

@kangax
Copy link
Member

kangax commented Apr 29, 2011

I looked into your example and the problem seems to be due to malformed fill value on a <rect> element. Once you set it to, say, "#00FF00" (not "00FF00" as it currently is) it should be displayed properly.

@fudini
Copy link
Author

fudini commented Apr 29, 2011

I fixed the color value. Now you can see the problem is not with the rectangle itself, but the elements after that. From my tests it looks like all the elements after seem to inherit some properties from it.

@kangax
Copy link
Member

kangax commented Apr 29, 2011

You're right, it was leaking. Fixed in 5c7440c Thanks!

@fudini
Copy link
Author

fudini commented Apr 30, 2011

No problem, I'm glad I could help.

asturur added a commit that referenced this issue Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants