Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add test for ServiceAccount SharedIndexInformer watching resources with labelSelectors #2895

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Mar 11, 2021

Description

  • Added test for SharedIndexInformer for a ServiceAccount type to monitor
    events filtered with labels across all namespaces and in a particular
    namespace to verify that the use case actually works on master.
  • Minor Cleanup in DefaultSharedIndexInfomerTest to avoid code
    duplication while setting MockServer expectations

Related to #2801

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

…Selectors

+ Added test for SharedIndexInformer for a ServiceAccount type to monitor
  events filtered with labels across all namespaces and in a particular
  namespace to verify that the use case actually works on master.
+ Minor Cleanup in DefaultSharedIndexInfomerTest to avoid code
  duplication while setting MockServer expectations

Related to fabric8io#2801
@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@manusa manusa merged commit 170b762 into fabric8io:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants