Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code smells in OperationContext class #2880

Merged
merged 1 commit into from
Mar 9, 2021
Merged

Reduce code smells in OperationContext class #2880

merged 1 commit into from
Mar 9, 2021

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Mar 5, 2021

Description

Reduce some code smells from OperationContext class, and also use primitive booleans in BaseOperation.

There is a small improvement in the with* instantiation of OperationContext where if the same value is provided, the same instance is returned instead of creating an unnecessary copy.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@centos-ci
Copy link

Can one of the admins verify this patch?

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021

@manusa manusa merged commit 0151361 into fabric8io:master Mar 9, 2021
@jorsol jorsol deleted the codesmells-OperationContext branch March 12, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants