Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- fixes microsoft translation by providing api region #3

Merged
merged 2 commits into from
Sep 2, 2020
Merged

- fixes microsoft translation by providing api region #3

merged 2 commits into from
Sep 2, 2020

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Aug 30, 2020 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • I have read the CONTRIBUTING doc.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been reviewed and added / updated if needed (for bug fixes / features).
  • Build (npm run build) was run locally and any changes were pushed.
  • Tests (npm test) has passed locally and any fixes were made for failures.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Microsoft made providing the region with the key mandatory as outlined here this pull request allows subscribers to specify their region so the call to the API works

Does this introduce a breaking change?

  • Yes
  • No

Other information

Note: unit tests are currently failing in the PR validation because PRs from forks don't have access to secrets for security reasons.

@baywet
Copy link
Contributor Author

baywet commented Sep 2, 2020

CC @fabasoad

@fabasoad
Copy link
Owner

fabasoad commented Sep 2, 2020

Thank you @baywet for this PR! Didn't have a chance to review it yet but I'll do my best to take a look at it tomorrow 🙂

@fabasoad
Copy link
Owner

fabasoad commented Sep 2, 2020

@baywet Thank you for contribution!

@fabasoad fabasoad merged commit 7c9ad76 into fabasoad:main Sep 2, 2020
@fabasoad fabasoad self-requested a review September 2, 2020 23:57
@fabasoad fabasoad added the bug label Sep 2, 2020
@baywet baywet deleted the bugfix/microsoft-region branch September 2, 2020 23:59
@baywet
Copy link
Contributor Author

baywet commented Sep 2, 2020

thanks for merging!

github-actions bot pushed a commit that referenced this pull request Jan 1, 2021
@fabasoad
Bump dependencies by "Check updates #3"
b60058f
fabasoad added a commit that referenced this pull request Jan 1, 2021
@github-actions @fabasoad
Bump dependencies by "Check updates #3" (#10)
f07885f 
* Bump dependencies by "Check updates #3"

* Add git secrets hooks

Co-authored-by: fabasoad <fabasoad@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabasoad fabasoad Awaiting requested review from fabasoad fabasoad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baywet @fabasoad