Implemented mandatory option for multiple choice entries. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ | |||
| // Created on: <10-Jun-2005 15:55:33 sp> | |||
| // | |||
|
|
|||
| // Copyright (C) 1999-2013 eZ Systems AS. All rights reserved. | |||
| // Copyright (C) 1999-2010 eZ Systems AS. All rights reserved. | |||
|
Thanks Sander for the contribution!! |
|
+0.5, review ping @patrickallaert, @bjornreiten ;) |
| @@ -316,6 +316,7 @@ function processViewActions( &$validation, $params ) | |||
|
|
|||
| $postSurveyAnswer = $prefix . '_ezsurvey_answer_' . $this->ID . '_' . $attributeID; | |||
| if ( !$http->hasPostVariable( $postSurveyAnswer ) and | |||
| $this->attribute('mandatory') and | |||
There was a problem hiding this comment.
CS: spaces around arguments inside ()
|
+1, but take into accounts the remarks of @andrerom and mines. |
|
Note that an enhancement request should exist in Jira which should be referenced by this PR/commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the option to make multiple choice entries mandatory has been removed from ezsurvey, and questions of this type are always mandatory. I don't know the exact motivation for this choice in the past, but fact is that for many people this is unwanted behavior.