EZP-32018: Fixed empty ezdate field transformation #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Oct 12, 2020
andrerom
approved these changes
Oct 12, 2020
andrerom
reviewed
Oct 12, 2020
|
👍 |
glye
approved these changes
Oct 12, 2020
|
@barw4 Can you merge this (squash, so the one using the UI here for instance), then merge 2019.03 into master, and if your up for it also release v2019.03.6 (I can show you how). |
|
Merged into master: 10902ec |
|
It's unlikely, but what about if you actually want the timestamp to be '0'? That would return NULL instead of 1.1.1970, right? |
|
@pkamps you are right. I am pretty sure that there have been changes not too long ago in the ez5 kernel to deal with 0/null as default and 0 as valid datetime. I think here we should reproduce the same logic (might be even worth some unit testing)... |
|
You're talking about this one? https://jira.ez.no/browse/EZP-16509 We fixed it in our fork - still an open pull request: mugoweb#188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA issue: EZP-32018
Empty field value for
ezdatefieldtype has been handled additionally.