Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of headings in table header cells #1457

Merged
merged 25 commits into from
Oct 12, 2020

Conversation

hknezevic
Copy link
Contributor

If you add heading element inside the regular table cell (td), it will be correctly applied, stored and displayed on the frontend.
If you try to do the same inside table header cell (th), after you store the changes, the heading will get moved from the header cell and placed below the table.

This PR fixes the incorrect behaviour.

andrerom and others added 24 commits May 15, 2019 19:59
Version is set to 2019.99-alpha1 as there isn't plans atm for what next
feature release will be if any, if there is needs for another feature
release community would need to drive that.

<ad>
With eZ Platform 2.5LTS being out and bringing more or less feature parity
with eZ Publish it's a good time to evaluate it again. With legacy bridge
support it's also a good version to migrate to if you have legacy needs.

Or if you are a developer then eZ Platform 3 comming this year might be of
interest for new projects, as one of it's core aims is to greatly improve
developer experience, closer integrate the CMS with Symfomny & lots more.
</ad>

Thanks for all the fish, I mean legacy!
* Popup for the custom tag sub/sup fixed

* Update extension/ezoe/design/standard/templates/ezoe/tag_custom.tpl

Co-Authored-By: André R. <andre.romcke@gmail.com>
Only check cache generation timeout when generation has actually started. Avoids SQL error.
…zsystems#1455)

eZObjectRelationList: Do not store the content object attribute in the fetch call, because it clears the object's data_map, which means other content object attributes cannot access the data map.
@pkamps
Copy link
Contributor

pkamps commented Jun 5, 2020

I was able to confirm the behaviour. I had to disable the editor in order to change the cells to .

@andrerom andrerom changed the base branch from master to 2019.03 June 23, 2020 11:39
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, but would you be able to rebase your change on top of 2019.03, or earlier stable releases (2017.12) for this fix?

@andrerom andrerom merged commit f21bbc5 into ezsystems:2019.03 Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants