PHP7.2 fix: Added array check before count. #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Feb 20, 2020
kernel/classes/datatypes/ezobjectrelationlist/ezobjectrelationlisttype.php
Outdated
Show resolved
Hide resolved
Check for existence of post variable Co-Authored-By: André R. <289757+andrerom@users.noreply.github.com>
andrerom
approved these changes
Feb 26, 2020
vidarl
approved these changes
Mar 18, 2020
pkamps
pushed a commit
to mugoweb/ezpublish-legacy
that referenced
this pull request
Apr 3, 2020
* Added array check before counting * Apply suggestions from code review Check for existence of post variable Co-Authored-By: André R. <289757+andrerom@users.noreply.github.com>
pkamps
added a commit
to mugoweb/ezpublish-legacy
that referenced
this pull request
Apr 3, 2020
* Added array check before counting * Apply suggestions from code review Check for existence of post variable Co-Authored-By: André R. <289757+andrerom@users.noreply.github.com> Co-authored-by: Stian Torjussen <53934716+StianTorjussen@users.noreply.github.com> Co-authored-by: André R. <289757+andrerom@users.noreply.github.com>
glye
pushed a commit
that referenced
this pull request
May 22, 2020
* Added array check before counting * Apply suggestions from code review Check for existence of post variable Co-Authored-By: André R. <289757+andrerom@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to get a post variable
$http->postVariable( $postVariableName )sometimes returnednull.Resulting in
count(null), which triggers a warning.Ref. phpdoc changelog for count:
https://www.php.net/manual/en/function.count.php#refsect1-function.count-changelog