Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Language Boost #90

Closed
wants to merge 1 commit into from
Closed

Conversation

harmstyler
Copy link

Language boost was boosting first language in the SiteLanguageList, not boosting the second language, and lowering the value of the third. It also disregarded any installation that had more than 3 languages. This update boosts the default siteaccess language only and leaves all others alone.

Language boost was boosting first language in the `SiteLanguageList`, not boosting the second language, and lowering the value of the third. It also disregarded any installation that had more than 3 languages. This update boosts the default siteaccess language and leaves all others alone.
@nfrp
Copy link
Contributor

nfrp commented Dec 13, 2012

Looks good to me, thanks for sharing!
Any particular use-case behind this functional change?

@harmstyler
Copy link
Author

Yeah, if you happen to be working on a site with more than 3 languages you will receive unexpected results when searching. The boost query as it was written boosted the first language on your site language list (^1.2), left the second alone (^1), and the third language on the list would be penalized with a ^.08 boost.

Rather than penalizing the third language on the list, only the first language on the list should be boosted.

@harmstyler harmstyler closed this Apr 19, 2019
@pkamps
Copy link
Contributor

pkamps commented Apr 29, 2019

I wasn't aware of this pull request. Any reason why you closed it? The patch makes sense to me.
Did you close it because nobody got back to you for 6 years?

@harmstyler
Copy link
Author

Yes, I figured it wasn't going anywhere.

@pkamps
Copy link
Contributor

pkamps commented Apr 29, 2019

I know the feeling... Thanks anyways for your effort.

@dougplant
Copy link

dougplant commented Apr 29, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants