Fixed problem of Invalid response for blob #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks so much for the PR! It looks like a fix for the underlying issue was submitted in facebook#18547 and merged, so we'll wait for this to get released and cherry-picked in the appropriate places. Thanks! |
|
@anp any estimate on when this might get merged in? This is a fairly significant bug, and the fix was originally authored to RN 24 days ago... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According with this: https://github.com/reyalpsirc/react-native/commit/6b1831e
Ios will throw Invalid response for blob error on empty response. Fetch ll auto handle request as blob now. This will happen on 0.54 and later ( so mainly affect sdk26+ , so sdk27 seems bugged too )
I am not the main author of this patch, i'm just forwarding this to expo pull requests. Probably need some verification
Related PRs
https://github.com/reyalpsirc/react-native/commit/6b1831e
xiamx@b35071b
facebook#18223
IMPORTANT NOTES
This is just workaround, It's not a real fix of this behavior , introducing some problems due if used as
blob, and get empty response blob is invalid. To this i suggest to see this one: xiamx@b35071b
That is it, so feel free to refuse this pull request and instead apply xiamx patch.
CATEGORY
[ BUGFIX ]