Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unit tests as appropriate #514

Conversation

lawson89
Copy link
Contributor

Skip unit tests as appropriate if functionality not configured (tasks) or loadable (xls-writer)

Issue #513

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #514 (d8c897e) into fix/optional-packages (4a13e2a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           fix/optional-packages     #514      +/-   ##
=========================================================
+ Coverage                  96.40%   96.44%   +0.04%     
=========================================================
  Files                         42       42              
  Lines                       2171     2196      +25     
=========================================================
+ Hits                        2093     2118      +25     
  Misses                        78       78              
Impacted Files Coverage Δ
explorer/tests/test_exporters.py 100.00% <100.00%> (ø)
explorer/tests/test_models.py 100.00% <100.00%> (ø)
explorer/tests/test_schema.py 100.00% <100.00%> (ø)
explorer/tests/test_tasks.py 100.00% <100.00%> (ø)
explorer/tests/test_views.py 100.00% <100.00%> (ø)
explorer/utils.py 88.88% <100.00%> (+0.55%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@marksweb marksweb merged commit d5d5831 into explorerhq:fix/optional-packages Dec 15, 2022
marksweb added a commit that referenced this pull request Dec 15, 2022
* Ensure there is a workflow run without optional packages

* Catch import error on celery

* Move boto3 to local import if the s3 upload is being used.

* Added workflow concurrency

* Add ENABLE_TASKS as env variable for tests

* Move factory boy into base test requirements

* Skip unit tests as appropriate if functionality not configured (tasks) or loadable (xls-writer) (#514)

Issue #513

Co-authored-by: Richard Lawson <lawson89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants