Allow Metric.score to work within an existing asyncio loop #1161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
jjmachan
reviewed
Aug 5, 2024
| @@ -96,7 +96,8 @@ def score(self: t.Self, row: t.Dict, callbacks: Callbacks = None) -> float: | |||
| callbacks = callbacks or [] | |||
| rm, group_cm = new_group(self.name, inputs=row, callbacks=callbacks) | |||
| try: | |||
| score = asyncio.run(self._ascore(row=row, callbacks=group_cm)) | |||
| loop = asyncio.get_event_loop() | |||
| score = loop.run_until_complete(self._ascore(row=row, callbacks=group_cm)) | |||
There was a problem hiding this comment.
this will still fail in jupyter notebook envs right?
dosubot
bot
added
size:M
|
added a few tests but thanks a lot for this PR ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got errors when running metrics within an existing asyncio loop, the
asyncio.runpart makes the code fail in those cases. Submitting a bugfix.